deps: add imageio-ffmpeg requirement to install.py #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes yownas#41 by adding imageio-ffmpeg to extension requirements/dependencies. This is required due to some changes with moviepy's underlying imageio library, which has deprecated/removed the old autoinstallation method around 2019-ish, and as such moviepy is no longer capable of autoinstalling ffmpeg. See Zulko/moviepy#906 and Zulko/moviepy#908 for further details on the moviepy side. This does result in downloading ffmpeg on systems where it may already be installed, but it's a reasonably small download and on some systems (eg Ubuntu 22.04) moviepy 1.0.3 fails to pick up system ffmpeg anyway.
|
Thank you. :) I hope this will fix some of the problems people have had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41 by adding imageio-ffmpeg to extension requirements/dependencies.
This is required due to some changes with moviepy's underlying imageio library, which has deprecated/removed the old autoinstallation method around 2019-ish, and as such moviepy is no longer capable of autoinstalling ffmpeg.
See Zulko/moviepy#906 and Zulko/moviepy#908 for further details on the moviepy side.
This does result in downloading ffmpeg on systems where it may already be installed, but it's a reasonably small download and on some systems (eg Ubuntu 22.04) moviepy 1.0.3 fails to pick up system ffmpeg anyway.